support listening on public interfaces #1
Closed
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of hardcoded loopback-only
r00t-
commented
Mar 17, 2017
| my_error (_ ("--local and --public are mutually exclusive\n")); | ||
|
|
||
| if (!local && !public) | ||
| public = 1; // default |
There was a problem hiding this comment.
note that this changes the default to public, which might not be desireable,
as it might make user's existing setups less secure.
r00t-
commented
Mar 17, 2017
| @@ -228,12 +232,21 @@ main (int argc, char *argv[]) | |||
| my_error (_ ("option parsing failed: %s\n"), error->message); | |||
| g_option_context_free (context); | |||
|
|
|||
| if (argc != 1) | |||
| my_error (_ ("unsupported extra arguments: %s ...\n"), argv[1]); | |||
There was a problem hiding this comment.
i fixed this bug on the way...
extra arguments were silently ignored.
|
Thank you for contributing to phodav! phodav uses Bugzilla for code review. If you have never contributed to GNOME before make sure you have read the Otherwise please visit |
|
was merged as ece391b |
gnomesysadmins
pushed a commit
that referenced
this pull request
May 10, 2021
meson: Allow specifying systemd/udev directories Closes #1 See merge request GNOME/phodav!19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of hardcoded loopback-only
chezdavis hardcoded to only ever listen on loopback,making it relatively useless.
the documentation does not warn the user about this.
it's even packaged on debian, and i ran into it looking for a webdav server,
and then had to patch this to make it actually useable.
note that this changes the default to public, which might not be desireable,
as it might make user's existing setups less secure.